fix: var naming and comment

lidofinance · Nov 11, 2024 · 21f51b8 · 21f51b8
1 parent 4a37dae
commit 21f51b8
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/contracts/Escrow.sol b/contracts/Escrow.sol
@@ -348,9 +348,12 @@ contract Escrow is IEscrow {
         uint256 maxStETHWithdrawalRequestAmount = WITHDRAWAL_QUEUE.MAX_STETH_WITHDRAWAL_AMOUNT();
 
         /// @dev The remaining stETH amount must be greater than the minimum threshold to create a withdrawal request.
-        uint256 remainingStETHThreshold = Math.max(_MIN_TRANSFERRABLE_ST_ETH_AMOUNT, minStETHWithdrawalRequestAmount);
+        ///     Using only `minStETHWithdrawalRequestAmount` is insufficient because it is an external variable
+        ///     that could be decreased independently. Introducing `minWithdrawableStETHAmount` provides
+        ///     an internal safeguard, enforcing a minimum threshold within the contract.
+        uint256 minWithdrawableStETHAmount = Math.max(_MIN_TRANSFERRABLE_ST_ETH_AMOUNT, minStETHWithdrawalRequestAmount);
 
-        if (stETHRemaining < remainingStETHThreshold) {
+        if (stETHRemaining < minWithdrawableStETHAmount) {
             return _batchesQueue.close();
         }
 
@@ -364,7 +367,7 @@ contract Escrow is IEscrow {
 
         stETHRemaining = ST_ETH.balanceOf(address(this));
 
-        if (stETHRemaining < remainingStETHThreshold) {
+        if (stETHRemaining < minWithdrawableStETHAmount) {
             _batchesQueue.close();
         }
     }