This repository was archived by the owner on Oct 23, 2025. It is now read-only.
feat: add mellow-vaults bot scaffold#555
Open
katamarinaki wants to merge 67 commits into
Open
Conversation
limits integrity (mellow-vaults) wstETH integrity(wstETH integrity) admin msig (multisig-watcher) AccessControl (multisig-watcher, ethereum-governance, multisig-watcher)
sergeyWh1te
suggested changes
Jun 10, 2024
katamarinaki
commented
Jun 10, 2024
katamarinaki
left a comment
katamarinaki
left a comment
Contributor
Author
There was a problem hiding this comment.
Please take a look at the review comments!
sergeyWh1te
suggested changes
Jul 22, 2024
sergeyWh1te
suggested changes
Jul 22, 2024
sergeyWh1te
left a comment
sergeyWh1te
left a comment
Contributor
There was a problem hiding this comment.
Main ideas where I'd like to see technical improvements.
- Network. Making network calls to handle transactions. If you debug the handleTransaction you can find that this method passes though itself a thousands transactions of the block.
- Local infra:
- Tests: They would not work in local infra. (Because it requires changing function's signature handleBlock, handleTx) I don't know do you or not roll out this bot in local env.
- Bot does not prepared for local infra.
- Found some duplicated pieces of the code
- Some variables are good to see as dependencies, not just consts. I see that you're planning to run bot in testnet. It means that constants would have different values. In future, you need to refactor this. Let's do it from the begging.
- Tests:
I'd be perfect to cover by tests network layer, especially when code grabs wide ranges of blocks like - HOURS_48 - Types. I would strongly adhere to the strict types. Not mixing js and ts approaches.
Ton of work.
Let's hit the gas into the floor and do it perfectly. 💪🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alerts for Mellow vaults