-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pie chart plugin #315
base: main
Are you sure you want to change the base?
Conversation
Hi @yukkysaito, The team will get back to you soon. |
Hello @yukkysaito We discussed this as a team and will evaluate your PR, leaving some comments for you. Best Regards, |
@luluiz @laisspportugal Thank you for your comment. I was on a business trip overseas until recently, so my reply was delayed. |
e209fda
to
d9538ab
Compare
Signed-off-by: Honda Takayuki <81165526+Tucker925H@users.noreply.github.com>
Signed-off-by: Yukihito Saito <yukky.saito@gmail.com>
type NodeEditorProps = { | ||
actionHandler: (action: SettingsTreeAction) => void; | ||
defaultOpen?: boolean; | ||
filter?: string; | ||
focusedPath?: readonly string[]; | ||
path: readonly string[]; | ||
settings?: Immutable<SettingsTreeNode>; | ||
panelTitle?: string; | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tucker925H This code is caused conflicts.
Could you please check?
yukky@yukky:~/workspace/lichtblick$ yarn run web:build:prod
webpack 5.98.0 compiled successfully in 52 ms
main:
assets by status 32.4 MiB [cached] 119 assets
orphan modules 20.7 MiB [orphan] 5462 modules
runtime modules 74.8 KiB 151 modules
built modules 49.1 MiB (javascript) 3.15 MiB (asset) [built]
modules by path ../../node_modules/ 43 MiB (javascript) 2.82 MiB (asset)
javascript modules 41.6 MiB 2322 modules
asset modules 486 KiB (javascript) 2.82 MiB (asset) 62 modules
json modules 887 KiB 16 modules
modules by path ../../packages/ 6.07 MiB (javascript) 340 KiB (asset) 194 modules
modules by path ./ 44.6 KiB
./entrypoint.tsx + 23 modules 44.6 KiB [built] [code generated]
./terminal-highlight (ignored) 15 bytes [built] [code generated]
modules by mime type image/svg+xml 3.17 KiB
data:image/svg+xml;base64,PHN2ZyB3aWR0aD0i.. 1.59 KiB [built] [code generated]
data:image/svg+xml;base64,PHN2ZyB3aWR0aD0i.. 1.59 KiB [built] [code generated]
+ 26 modules
ERROR in ./packages/suite-base/src/components/SettingsTreeEditor/NodeEditor.tsx:32:3
TS2440: Import declaration conflicts with local declaration of 'NodeEditorProps'.
30 | import { useStyles } from "@lichtblick/suite-base/components/SettingsTreeEditor/NodeEditor.style";
31 | import {
> 32 | NodeEditorProps,
| ^^^^^^^^^^^^^^^
33 | SelectVisibilityFilterValue,
34 | } from "@lichtblick/suite-base/components/SettingsTreeEditor/types";
35 | import Stack from "@lichtblick/suite-base/components/Stack";
User-Facing Changes
Thank you for maintaining Lichtblick.
I have created a plugin to display a float32 array as a pie chart. I developed it based on the Gauge plugin and used Recharts as the foundation. However, I’m not yet familiar with Lichtblick's coding practices, so the current implementation is just at a functional level. Could you kindly provide support on what would be needed to make it suitable for merging?
Additionally, the Gauge plugin I referenced has recently undergone significant refactoring in this PR. The Pie Chart plugin was developed based on the pre-refactored version.

Description
Screencast.from.2024.12.10.22.49.54.webm
I plan to organize the commit history later.
Checklist