This repository was archived by the owner on Feb 18, 2026. It is now read-only.
Messages: replace instead of push state to match web#1675
Open
jas14 wants to merge 1 commit intolichess-org:masterfrom
Open
Messages: replace instead of push state to match web#1675jas14 wants to merge 1 commit intolichess-org:masterfrom
jas14 wants to merge 1 commit intolichess-org:masterfrom
Conversation
Collaborator
|
Thanks! I need to test this in order to understand exactly what's going on here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May fix #1659. The mobile app used
History.pushStatewhere the website usedHistory.replaceState, which made it difficult to navigate out of chat using the native back button after opening conversations many times.After this PR, the messages behavior will be as follows:
/inbox, will be replaced with the conversation path (/inbox/<userId>).This means that at any point in the messages UI, hitting the native "back" button will exit the messages UI entirely. I don't love this behavior, but 1) it matches the website and 2) I see no way to avoid it without relying on
history.back(), which would cause an unnecessary XHR reload of the inbox.Tested locally using Chrome.