correct ARMO/WEAP layouts - #18
Merged
Merged
Conversation
- fix TESObjectREFR base layout by removing the phantom BSTransformDeltaEvent sink, swapping ActorValueOwner / IKeywordFormBase, and restoring the missing padding before data - update TESObjectARMO so attachParents is modeled as a raw BGSTypedKeywordValueArray<KeywordType::kAttachPoint> at 0x328 - update TESObjectWEAP so attachParents remains the component-backed BGSAttachParentArray at 0x250, with shifted formEditorID / weaponData offsets TESObjectARMO and TESObjectWEAP appear to store the same gameplay concept with different concrete runtime layouts, so this change intentionally models them asymmetrically.
ozooma10
marked this pull request as draft
April 16, 2026 20:15
ozooma10
marked this pull request as ready for review
April 16, 2026 20:46
not needed for weap/armo fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updateTESObjectARMO to match the runtime-validated layout:
modelArray is BSTArray at 0x310
attachParents is a full BGSAttachParentArray at 0x320
0x320 is the component vtable, with begin/end/cap at 0x328/0x330/0x338
update TESObjectWEAP for BGSAttachParentArray at 0x250, with shifted formEditorID / weaponData offsets
Tried to validate by inspecting runtime memory layouts