log: Remove NGAGE hackery. #14321
Open
log: Remove NGAGE hackery. #14321
+7
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code bypasses the ability to set/get a log function, and seems to be a temporary hack that was merged by mistake.
This reintroduces the NGAGE file logging previously removed from the formatting function, into SDL_LogOutput() instead. Following the pattern of the 3DS, VITA, PSP, etc.
|
Pushed a commit that (unconditionally) reintroduces file logging, based on the code that I removed previously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was introduced in #12148 (commit 7ae6459) and looks like debug code to me.
I don't know anything about the NGAGE platform, so forgive me if I'm missing something, but I doubt it requires this hackery in the middle of the main log function.
Seems the way this works is that the buffer is actually logged as a side-effect of calling
NGAGE_vnprintf()which contains a call toRDebug::Print();?All other platforms do their logging inside the
SDL_LogOutput()function, and I believe this code should be moved there. There is an NGAGE block there, that is currenly empty.I'll defer to @mupfdev