Skip to content

fix(supersearch): Ensure arrow key handling is reset when clicking expanded input #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johanbissemattsson merged 2 commits into from
Aug 12, 2026
Merged

fix(supersearch): Ensure arrow key handling is reset when clicking expanded input #1652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d52be38
Ensure arrow key handling is reset when clicking expanded input
johanbissemattsson Aug 12, 2026
176b274
Add test
jesperengstrom Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/supersearch/e2e/supersearch.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,23 @@ test('supports keyboard navigation between rows and columns/cells', async ({ pag
).toHaveAttribute('aria-activedescendant', 'supersearch-item-2x0');
});

// Ensure https://github.com/libris/lxlviewer/pull/1652 does not regress
test('ensure arrow key handling is reset when clicking expanded input', async ({ page }) => {
await page.getByRole('combobox').click();
await page.getByRole('dialog').getByRole('combobox').fill('abde');
await page.waitForResponse(
(res) => res.url().includes('/api/find?_q=abde') && res.status() === 200
);
await page.keyboard.press('ArrowDown');
await page.keyboard.press('ArrowDown');
await page.keyboard.press('ArrowDown');
await page.getByRole('dialog').getByRole('combobox').click();
await page.keyboard.press('ArrowLeft');
await page.keyboard.press('ArrowLeft');
await page.keyboard.press('c');
await expect(page.getByRole('dialog').getByRole('combobox')).toHaveText('abcde');
});

test('user can toggle expanded search using alt key + arrow up or down (without moving cursor) ', async ({
page
}) => {
Expand Down
1 change: 1 addition & 0 deletions packages/supersearch/src/lib/components/SuperSearch.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@
activeColIndex = defaultResultCol;
} else {
activeColIndex = defaultInputCol;
allowArrowKeyCursorHandling = { vertical: false, horizontal: true };
}
}

Expand Down
Loading