Merged
Conversation
johanbissemattsson
approved these changes
Feb 26, 2026
Contributor
There was a problem hiding this comment.
Looks good code-wise! 👍 I'm looking forward to using this in action!
I think it makes sense to do getPropertiesByCategory('searchFilter') once in hooks.server.ts.
We could also add an cached /api/searchFilters/+server.ts route which SuperSearchWrapper can fetch the required data from.
41806d8 to
55292f6
Compare
Add route /help/filters for listing all available search filters.
278e276 to
861fbd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on libris/definitions#560
supersearch
help page
POC
Add route /help/filters for listing all available search filters.
How do we want to render them? table? cards? etc
I think we should display:
Tickets involved
LXL-4648
Summary of changes
getPropertiesByCategoryto VocabUtilTODO
getPropertiesByCategory('searchFilter')only once in hooks.server.ts?:comment?