LXL-4716 - Validation on field category, show warning when identify or find (or both) is missing #1403
LXL-4716 - Validation on field category, show warning when identify or find (or both) is missing #1403marigonahaxha wants to merge 13 commits intodevelopfrom
Conversation
marigonahaxha
requested review from
lrosenstrom and
olovy
and removed request for
lrosenstrom and
olovy
lrosenstrom
left a comment
lrosenstrom
left a comment
There was a problem hiding this comment.
This is a start but it needs more work! See comments in the code.
| :parent-path="editingObject" | ||
| :bulk-context="bulkContext" | ||
| :show-key="!hideTopLevelFieldNames" | ||
| :itemData="inspector.data.mainEntity" |
There was a problem hiding this comment.
This would pass the whole record as a property to each field instance, so not a good idea!
| itemData: { | ||
| type: Object, | ||
| default: null, | ||
| }, |
|
|
||
| if(this.archType === 'Instance') { | ||
| find = this.itemData?.instanceOf?._categoryByCollection?.find; | ||
| } |
There was a problem hiding this comment.
Instead of getting _categoryByCollection from the record, you can check if this.fieldKey === _categoryByCollection. Find, identify and @none can be obtained from this.fieldValue. You can check this.parentPath to tell if this is category in the local work on the instance or on the instance level.
| let identify = null | ||
|
|
||
| if(this.archType === 'Instance') { | ||
| identify = this.itemData?.instanceOf?._categoryByCollection?.identify; |
| ); | ||
|
|
||
| const customMessages = { | ||
| Find: StringUtil.getUiPhraseByLang( |
There was a problem hiding this comment.
Prefer the shorter translatePhrase method.
|
There's a couple of bugs in the rendering of the warning. The whole field gets a hand cursor although most of it is not clickable. |
lrosenstrom
force-pushed
the
lxl-4716-validation-onidentify--category-field
branch
from
deaefbe to
31936b8
Compare
2 participants
Checklist:
yarn test:unityarn lintDescription
Tickets involved
LXL-4716
Solves
Shows an error warning if the field
findoridentifyor both are missing in the category field. Shows the warning in different places if it's aWorkor anInstance.Summary of changes
Tested on these items:
Screenshots