Skip to content

chore(lxlweb, supersearch): Bump dependencies - #1344

Merged
johanbissemattsson merged 42 commits into
developfrom
chore-lxlweb-bump-dependencies
Aug 13, 2025
Merged

chore(lxlweb, supersearch): Bump dependencies#1344
johanbissemattsson merged 42 commits into
developfrom
chore-lxlweb-bump-dependencies

Conversation

@johanbissemattsson

@johanbissemattsson johanbissemattsson commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

Description

Solves

Bumps dependencies in lxl-web and supersearch (together with codemirror-lang-lxlquery)

Summary of changes

  • Bump dependencies to latest version with some exceptions... see below 👇
  • sveltejs/kit uses 2.27.1 instead of 2.28.0 due to a newly introduced bug causing tests to fail
  • codemirror/view is kept at 6.36.6 as the aria-placeholder attribute added in 6.36.7 doesn't play nicely with role="combobox", causing AXE accessibility tests to fail. We should decide if we should supress these errors or work around it in some other way. See https://discuss.codemirror.net/t/accessibility-violation-in-placeholder/9165/14
  • Upgrade vite to version 7 (this will add Node ^22.12 as a requirement).
  • Harmonize files following Sveltes starter templates
  • Add lang="ts" to <script module>
  • Fix issue with multiple candidate TSConfigRootDirs
  • Ensure local dependencies are built beforehand (resolving "Failed to resolve entry for package" in github actions)
  • Replace deprecated rollup-plugin-ts with @rollup/plugin-typescript

Note that Node version 22.12 or above is now needed!

aria-placeholder added in 6.36.7 doesn't play nicely with role="combobox". We should decide if we should supress these errors or work around it in some other way. See https://discuss.codemirror.net/t/accessibility-violation-in-placeholder/9165/14
This should hopefully resolve the issue "Failed to resolve entry for package" in github actions
@johanbissemattsson
johanbissemattsson force-pushed the chore-lxlweb-bump-dependencies branch 2 times, most recently from 4e16d9a to 5945554 Compare August 13, 2025 11:05
@johanbissemattsson
johanbissemattsson force-pushed the chore-lxlweb-bump-dependencies branch from 5945554 to e3c4c1c Compare August 13, 2025 11:10
@johanbissemattsson

johanbissemattsson commented Aug 13, 2025

Copy link
Copy Markdown
Contributor Author

There were some issues regarding missing dependencies on CI enviroments (resulting in failing GitHub Actions) but 722bd47 together with e3c4c1c seems to resolve the issues.

However it still works when removing the workarounds so keeping the updated package-lock.json file should be enough.

@jesperengstrom jesperengstrom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! ⭐
Everything seems to work just fine.

@johanbissemattsson
johanbissemattsson merged commit 10aae0d into develop Aug 13, 2025
4 checks passed
@johanbissemattsson
johanbissemattsson deleted the chore-lxlweb-bump-dependencies branch August 13, 2025 11:46
johanbissemattsson added a commit that referenced this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants