Improve backwards scanning to skip no more than one checkpoint #18328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tweak settings menu to allow defining replay checkpoint intervals at 1 second resolution instead of 60 second resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tweak settings menu to allow defining replay checkpoint intervals at 1 second resolution instead of 60 second resolution.
This makes scanning backwards through checkpoints feel much better (you can manually make a checkpoint then scan back to get to it more easily) especially if both automatic and manual checkpoints are happening. It also makes it easier to set reasonably short checkpoint intervals without messing around with text config files.