Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GossipSub 1.2] Allow sending IDONTWANTs when publishing #642

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[GossipSub 1.2] Allow sending IDONTWANTs when publishing #642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pubsub/gossipsub/gossipsub-v1.2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ This section lists the configuration parameters that needs to agreed on across c
When the peer receives the first message instance it immediately broadcasts
(not queue for later piggybacking) `IDONTWANT` with the `messageId` to all its mesh peers.
This could be performed prior to the message validation to further increase the effectiveness of the approach.
Additionally, on networks where multiple messages share the same messageId, a user may choose to broadcast IDONTWANT when publishing.
Copy link
Contributor

@ppopth ppopth Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to note that the publisher still shouldn't publish the message to the peers that previously sent an IDONTWANT to the publisher.

It's trivial to know this but I'm afraid that some implementers will forget this.


On the other side a node maintains per-peer `dont_send_message_ids` set. Upon receiving `IDONTWANT` from
a peer the `messageId` is added to the `dont_send_message_ids` set.
Expand Down