Skip to content

chore(request-reponse): use tokio test-swarm#6063

Merged
mergify[bot] merged 1 commit intolibp2p:masterfrom
elenaf9:request-response/use-tokio-test-swarm
Jun 18, 2025
Merged

chore(request-reponse): use tokio test-swarm#6063
mergify[bot] merged 1 commit intolibp2p:masterfrom
elenaf9:request-response/use-tokio-test-swarm

Conversation

@elenaf9
Copy link
Member

@elenaf9 elenaf9 commented Jun 17, 2025

Description

Amendment to #5857.
#5857 changed the tests in libp2p-request-response to use tokio as executor.
We forgot to also change the test-swarm's executor to use tokio instead of async_std (see #6024), so this PR fixes it.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@elenaf9 elenaf9 requested a review from jxs June 17, 2025 16:52
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Elena! ❤️

@jxs jxs added the send-it label Jun 18, 2025
@mergify mergify bot merged commit 5e413c3 into libp2p:master Jun 18, 2025
71 checks passed
@elenaf9 elenaf9 deleted the request-response/use-tokio-test-swarm branch June 18, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants