Skip to content

chore: update hickory dns to 0.25.2 #6033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 18 additions & 19 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ libp2p-autonat = { version = "0.14.1", path = "protocols/autonat" }
libp2p-connection-limits = { version = "0.5.1", path = "misc/connection-limits" }
libp2p-core = { version = "0.43.1", path = "core" }
libp2p-dcutr = { version = "0.13.0", path = "protocols/dcutr" }
libp2p-dns = { version = "0.44.0", path = "transports/dns" }
libp2p-dns = { version = "0.44.1", path = "transports/dns" }
libp2p-floodsub = { version = "0.46.1", path = "protocols/floodsub" }
libp2p-gossipsub = { version = "0.49.0", path = "protocols/gossipsub" }
libp2p-identify = { version = "0.47.0", path = "protocols/identify" }
Expand Down Expand Up @@ -126,8 +126,8 @@ futures-bounded = { version = "0.2.4" }
futures-rustls = { version = "0.26.0", default-features = false }
getrandom = "0.2"
if-watch = "3.2.1"
hickory-proto = { version = "0.25.0-alpha.4", default-features = false }
hickory-resolver = { version = "0.25.0-alpha.4", default-features = false }
hickory-proto = { version = "0.25.2", default-features = false }
hickory-resolver = { version = "0.25.2", default-features = false }
multiaddr = "0.18.1"
multihash = "0.19.1"
multistream-select = { version = "0.13.0", path = "misc/multistream-select" }
Expand Down
11 changes: 8 additions & 3 deletions transports/dns/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
## 0.44.1

- Update hickory-dns crate to 0.25.2
See [PR 6033](https://github.com/libp2p/rust-libp2p/pull/6033).

## 0.44.0
- Report all transport errors in a dial attempt instead of only returning the last error.

- Report all transport errors in a dial attempt instead of only returning the last error.
See [PR 5899](https://github.com/libp2p/rust-libp2p/pull/5899).

## 0.43.0

- Upgrade `async-std-resolver` and `hickory-resolver`.
Expand Down
4 changes: 2 additions & 2 deletions transports/dns/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "libp2p-dns"
edition.workspace = true
rust-version = { workspace = true }
description = "DNS transport implementation for libp2p"
version = "0.44.0"
version = "0.44.1"
authors = ["Parity Technologies <[email protected]>"]
license = "MIT"
repository = "https://github.com/libp2p/rust-libp2p"
Expand All @@ -29,7 +29,7 @@ tracing-subscriber = { workspace = true, features = ["env-filter"] }

[features]
async-std = ["async-std-resolver"]
tokio = ["hickory-resolver/tokio-runtime"]
tokio = ["hickory-resolver/tokio"]

# Passing arguments to the docsrs builder in order to properly document cfg's.
# More information: https://docs.rs/about/builds#cross-compiling
Expand Down
9 changes: 7 additions & 2 deletions transports/dns/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ pub mod async_std {
pub mod tokio {
use std::sync::Arc;

use hickory_resolver::{system_conf, TokioResolver};
use hickory_resolver::{name_server::TokioConnectionProvider, system_conf, TokioResolver};
use parking_lot::Mutex;

/// A `Transport` wrapper for performing DNS lookups when dialing `Multiaddr`esses
Expand All @@ -140,7 +140,12 @@ pub mod tokio {
) -> Transport<T> {
Transport {
inner: Arc::new(Mutex::new(inner)),
resolver: TokioResolver::tokio(cfg, opts),
resolver: TokioResolver::builder_with_config(
cfg,
TokioConnectionProvider::default(),
)
.with_options(opts)
.build(),
}
}
}
Expand Down
Loading