Skip to content

feat(swarm): add Option<PeerId> to IncomingConnectionError #6032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 27, 2025
Merged

feat(swarm): add Option<PeerId> to IncomingConnectionError #6032

merged 8 commits into from
May 27, 2025
+41 −1

Conversation

DougAnderson444
Copy link
Contributor

@DougAnderson444 DougAnderson444 commented May 23, 2025 •
edited
Loading

Description

Fixes #6025
Supercedes #6027

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@DougAnderson444 DougAnderson444 marked this pull request as ready for review May 23, 2025 13:17
@DougAnderson444 DougAnderson444 mentioned this pull request May 23, 2025
Closed
@DougAnderson444 DougAnderson444 changed the title add Option<PeerId> to IncomingConnectionError feat(swarm): add Option<PeerId> to IncomingConnectionError May 23, 2025
@DougAnderson444 DougAnderson444 mentioned this pull request May 23, 2025
Closed
4 tasks
elenaf9
elenaf9 approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @jxs

jxs
jxs approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks Doug for this and Elena for the improvement!

@jxs jxs added the send-it label May 27, 2025
@mergify mergify bot merged commit c54c0f2 into libp2p:master May 27, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

@elenaf9 elenaf9 elenaf9 approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose PeerId in connection-limits crate
3 participants
@DougAnderson444 @jxs @elenaf9