fix: add Gossipsub protocol to ALLOWED_PROTOCOLS in identify metrics#5992
Closed
Pronoss wants to merge 1 commit intolibp2p:masterfrom
Pronoss:fix/update
Closed
fix: add Gossipsub protocol to ALLOWED_PROTOCOLS in identify metrics#5992Pronoss wants to merge 1 commit intolibp2p:masterfrom Pronoss:fix/update
Pronoss wants to merge 1 commit intolibp2p:masterfrom
Pronoss:fix/update
Conversation
Author
|
Hi @libp2p/rust-libp2p-maintainers – just a friendly reminder about PR #5992 (“fix: add Gossipsub protocol to ALLOWED_PROTOCOLS in identify metrics”). It conditionally includes |
Member
|
This PR doesn't make any sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a TODO by adding the
GOSSIPSUB_PROTOCOL_IDfromlibp2p_gossipsubto theALLOWED_PROTOCOLSlist used in theidentifymetrics module.Previously, the Gossipsub protocol was commented out with a TODO placeholder. Now, it's conditionally included when the
gossipsubfeature is enabled, ensuring metrics can correctly account for Gossipsub-supporting peers.Change checklist