Skip to content

chore: deprecate async-io support in mDNS crate #5958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

chore: deprecate async-io support in mDNS crate #5958

wants to merge 11 commits into from

Conversation

gitToki
Copy link

@gitToki gitToki commented Mar 26, 2025

ref #5935

crate to update:
swarm, mDNS, and the transports TCP, QUIC and DNS.

@gitToki gitToki changed the title chore: deprecate async_std support in mDNS crate chore: deprecate async_io support in mDNS crate Mar 26, 2025
@gitToki gitToki changed the title chore: deprecate async_io support in mDNS crate chore: deprecate async-io support in mDNS crate Mar 26, 2025
jxs
jxs reviewed May 22, 2025
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gitToki thanks for this, looks good to me, but this needs a CHANGELOG.md entry and a minor version bump as removing it is a breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitToki @jxs