Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kad): remove default constructor for ProtocolConfig #5774

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

drHuangMHT
Copy link
Contributor

@drHuangMHT drHuangMHT commented Dec 30, 2024

Description

Remove items that were deprecated in #5122.

Notes & open questions

0.47.0 for libp2p-kad doesn't seem to be released on crates.io(latest 0.46.2) but changelog entry has reached 0.47.1.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@elenaf9 elenaf9 mentioned this pull request Dec 30, 2024
4 tasks
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to me. Could you update the changelog. Probably after #5776 is merged?

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks DrHuang! LGTM!

@jxs jxs added the send-it label Jan 3, 2025
@mergify mergify bot merged commit 40550dc into libp2p:master Jan 3, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants