feat(peer-store): introduce libp2p-peer-store #5724
Conversation
|
This is a very basic implementation, would love to hear more ideas on how to implement this! |
There was a problem hiding this comment.
Thanks for starting this effort @drHuangMHT!
If I understand the current implementation correctly, the purpose of this store is just to track connected peers, and explicitly added addresses. However, I think we have to keep in mind that protocols like kademlia or identify very frequently report all addresses that they learn as NewExternalAddrOfPeer. So with the current MemoryStore implementation, the store would grow unbounded with all of these addresses. I think there needs to be some GC strategy.
Also, after reading #4103 (comment), I think a peer store implementation could also do much more than just track explicitly added addresses, e.g.:
- track how valuable a know address is, by using infos about how the address info was received, if we connected to it already, etc
- implement a TTL for address records
- track other meta data for a peer, e.g. public key
I don't think this needs to be implemented in this PR. But I think we could forward more of the already present info to the Store trait, so that a custom implementation can have more sophisticated logic.
simplify Store trait, don't report conencted unless confirmed by swarm event
|
Oops that |
There was a problem hiding this comment.
Thanks for starting this @drHuangMHT, already looking good! left some notes to allow further customization.
cc @elenaf9
Store now handles FromSwarm directly; rename some on_* methods; allow removing address; update records on FromSwarm::ConnectionEstablished
This can get very complicated very soon, for example how to record the activitiy on the address(there will be some overhead) and how to make it machine-readable(scoring system). The discussion will be quite lengthy.
I didn't see a good way to implement TTL(garbage collect) for records, any pointer?
I don't see the remote public key being available through swarm itself, be it in the form of |
|
I forgot this very important reason why I want to support |
There was a problem hiding this comment.
I forgot this very important reason why I want to support libp2p::core::PeerRecord(signed addresses) here in peer store: gossipsub PeerEXchange! So this is a series of PR preceding it: #5785 makes Identify a source of PeerRecord, this PR allow us to store it and I'm planning on one to enable the use of it in gossipsub.
@jxs thoughts?
Hi Dr Huang, can we do it on a subsequent PR?
When the `MemoryStore` receives a `FromSwarm::DialFailure` event, it will now modify the store appropriately: - `LocalPeerId`: Remove the peer from the store. - `WrongPeerId`: Remove the address for the dialed peer ID and readd it for the received peer ID. - `Transport`: Remove the failed addresses from the store. - other: no action. Furthermore, we group some repeated event logic in a new function `push_event_and_wake` for internal use. Follow-up to #5724 Pull-Request: #5926.
Description
Introduce
libp2p-peer-storefor a peer store implementation.Related: #4103
Notes & open questions
Change checklist