Enhancement: Fix Kademlia DHT Bootstrap by Using Connected Peers as Fallback #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SuchitraSwain Could you please rebase your branch on the latest main branch? |
|
@SuchitraSwain : HI Suchitra, wish if you could resolve the merge conflicts. Re-ran the CI/Cd pipeline. Please arrive at a good conclusion on the test results. CCing @sumanjeet0012 |
|
@seetadev please Re-ran the CI/Cd pipeline. |
sumanjeet0012
suggested changes
Sep 23, 2025
There was a problem hiding this comment.
@SuchitraSwain There are a couple of issues in this PR:
1. The branch contains some previous commits from another branch. Please rebase it on the latest main branch.
2. The main objective of this PR is to ensure that, in case of fewer peers in the routing table, the connected peers are used for the random walk, But here this logic is used in multiple places like find node which is not required.
3. I have also added comments regarding some minor issues in this PR.
libp2p/kad_dht/kad_dht.py
Outdated
| ) | ||
|
|
||
| # Fallback to connected peers if routing table has insufficient peers | ||
| MIN_PEERS_THRESHOLD = 5 # Configurable minimum |
There was a problem hiding this comment.
Constants should be placed at top.
libp2p/kad_dht/kad_dht.py
Outdated
| connected_peers = self.host.get_connected_peers() | ||
| if connected_peers: | ||
| # Sort connected peers by distance to target and use as response | ||
| from .utils import sort_peer_ids_by_distance |
There was a problem hiding this comment.
import statements should be placed at top.
|
@sumanjeet0012 I will address the comments by today |
|
@SuchitraSwain @yashksaini-coder The PR also contains some commits from flood publishing PR, |
…age propagation tests
- Added tests to ensure fallback to connected peers when routing table has insufficient peers. - Improved flood publish tests for message propagation in various network topologies. - Cleaned up temporary file handling tests for better readability.
… PeerRouting modules
…across multiple modules
…le modules - Updated logging statements in `peer_routing.py` to improve readability by splitting long lines. - Refactored debug logs in `messages.py` to use parameterized logging for better performance and consistency. - Enhanced logging in `yamux.py` to use formatted strings for clarity and consistency. - Improved logging in `connection.py` and `listener.py` for QUIC transport to ensure consistent formatting. - Standardized logging in `security.py` for TLS handling to use parameterized strings. - Updated logging in `transport_registry.py` to maintain consistency in log formatting. - Refined logging in `websocket` transport files to ensure uniformity in message formatting. - Adjusted assertions in test files to use formatted strings for better readability and consistency.
…in QUICConnection and other modules
…mprove host connection logic
…D and add refresh_routing_table method
…sses for improved readability
… WebsocketListener, and YamuxStream classes; adjust formatting in test_gossipsub.py for clarity
…ve data handling and certificate loading security in TLSTransport
…ICListener and remove redundant import in WebsocketTransport
…CConnection stream initialization for clarity; add static method _multiaddr_from_socket in WebsocketListener class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #905
### What was wrong?
### How was it fixed?
A fallback mechanism was implemented in the DHT query logic:
✅ Benefits
To-Do
Cute Animal Picture