Skip to content

Conversation

asmit27rai
Copy link

@asmit27rai asmit27rai commented Sep 17, 2025

Description

Hole Punching Interop between go-libp2p and py-libp2p.

Test

cd py-libp2p/tests/interop/go_libp2p/hole_punching
chmod +x test_local.sh
./test_local.sh

Thanks

Fix : #733

@asmit27rai
Copy link
Author

@seetadev Please Review This PR.
Thanks

@seetadev
Copy link
Contributor

@asmit27rai : Thank you for submitting the PR. Appreciate it.

CCing @sukhman-sukh, @acul71 and @Winter-Soren, who will review your PR and share feedback points soon.

I'll review it on my side as well.

@seetadev
Copy link
Contributor

@asmit27rai : Re-ran the CI/CD pipeline. Please resolve the test failure issue.

@acul71
Copy link
Contributor

acul71 commented Sep 22, 2025

Hello @asmit27rai
I've been trying this PR, the test struct is working.
I've seen you're testing circuit relays, I'm guessing next you'll implement

  • Use /libp2p/dcutr protocol
  • Implement DCUtR message exchange (CONNECT/SYNC messages)
  • Add observed address exchange logic
  • Implement direct connection attempt after DCUtR exchange

@seetadev
Copy link
Contributor

@asmit27rai : Kindly reply to Luca's feedback. We should get this PR ready soon.

@asmit27rai
Copy link
Author

Hello @asmit27rai I've been trying this PR, the test struct is working. I've seen you're testing circuit relays, I'm guessing next you'll implement

  • Use /libp2p/dcutr protocol
  • Implement DCUtR message exchange (CONNECT/SYNC messages)
  • Add observed address exchange logic
  • Implement direct connection attempt after DCUtR exchange

Hello @asmit27rai I've been trying this PR, the test struct is working. I've seen you're testing circuit relays, I'm guessing next you'll implement

  • Use /libp2p/dcutr protocol
  • Implement DCUtR message exchange (CONNECT/SYNC messages)
  • Add observed address exchange logic
  • Implement direct connection attempt after DCUtR exchange

Yes. I am planning in same way.
Once this PR merged I will start working on this and may be raise a PR for this.
@acul71

@seetadev
Copy link
Contributor

@asmit27rai and @acul71 : Please resolve the CI/CD issues.

@acul71
Copy link
Contributor

acul71 commented Sep 22, 2025

@asmit27rai and @acul71 : Please resolve the CI/CD issues.

Sorry for some reason I can't see the failing CI/CD issues here. checking out asmit27rai:Hole_punch_gopy
I'll check the PR

@asmit27rai
Copy link
Author

@seetadev @acul71 Please have a look and review the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hole Punching Interop Tests for py-libp2p with other libp2p modules

3 participants