Migrate to log/slog
#633
Merged
Migrate to log/slog
#633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
approved these changes
Sep 11, 2025
gossipsub.go
Outdated
| score := gs.score.Score(p) | ||
| if score < gs.gossipThreshold { | ||
| log.Debugf("IWANT: ignoring peer %s with score below threshold [score = %f]", p, score) | ||
| gs.p.logger.Debug("IWANT: ignoring peer with score below threshold", "peer", p, "score", score) |
There was a problem hiding this comment.
NIT: I'd just have the logger reference on gs. So we can do gs.logger.Debug
Comment on lines
+520
to
+521
| ps.rpcLogger = slog.New(ps.logger.Handler().WithAttrs([]slog.Attr{slog.String("system", "pubsub/rpc")})) | ||
| } |
There was a problem hiding this comment.
Is there a way to enable only these rpc logs?
There was a problem hiding this comment.
yes. You pass a custom rpcLogger
MarcoPolo
force-pushed
the
marco/slog
branch
from
47a12ea to
648b0ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to libp2p/go-libp2p#3362.
Currently inlines an internal
gologshim.gopackage to maintain ipfs/go-log environment variable compatibility. Once libp2p/go-libp2p#3364 is merged, we can use the gologshim package in go-libp2p.