Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status code int32_t -> long #1178

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Status code int32_t -> long #1178

merged 1 commit into from
Feb 12, 2025

Conversation

liyishuai
Copy link
Contributor

per #325 (comment):

The current Response class uses int32_t for the status code, so this should probably match up.

350b0f8 changed the status_code from int32_t to long. This PR is to align the datatypes.

@COM8 COM8 self-requested a review February 12, 2025 16:35
@COM8 COM8 added this to the CPR 1.12.0 milestone Feb 12, 2025
COM8
COM8 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@COM8 COM8 merged commit 9ae5818 into libcpr:master Feb 12, 2025
43 of 44 checks passed
@liyishuai liyishuai deleted the long-status branch February 13, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@COM8 COM8 COM8 approved these changes

Assignees

@liyishuai liyishuai

Labels
Enhancement 👌
Projects
None yet
Milestone
CPR 1.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@liyishuai @COM8