Thread Pool Fix High CPU Load When Paused #1039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1035.
Switched from a
yield
based approach to a conditional variable based approach. Now all threads paused inside a thread pool are properly paused and do not consume a lot of CPU cycles while waiting.With this PR I'm also adding additional Thread Pool test cases. They are disabled right now since there is a bug causing them to get stuck inside the:
Probably the notify is not working correctly here. This will be fixed by a follow up PR.