Skip to content

docs: adding install instructions for uv, and gitignore update for vs…#24

Closed
djtjwillia wants to merge 4 commits into
liatrio-labs:mainfrom
djtjwillia:add-uv-install-to-docs
Closed

docs: adding install instructions for uv, and gitignore update for vs…#24
djtjwillia wants to merge 4 commits into
liatrio-labs:mainfrom
djtjwillia:add-uv-install-to-docs

Conversation

@djtjwillia
Copy link
Copy Markdown

@djtjwillia djtjwillia commented Oct 28, 2025

…code

Why?

Clarifying the docs to give instructions on installing uv via brew

What Changed?

Addition to the readme, and an update to the .gitignore

Additional Notes

  • Linked relevant spec/task IDs (e.g., tasks/0002-spec-open-source-ready.md)
  • Ran tests: uv run pytest
  • Ran linters/hooks: uv run pre-commit run --all-files
  • Updated docs or prompts if behavior changed

Summary by CodeRabbit

  • Documentation

    • Added a clearer TL;DR instructing users to ensure the "uv" tool is installed, with explicit install instructions for macOS and Linux (brew install uv), so prerequisite setup is clearer.
  • Chores

    • Updated project configuration to ignore editor workspace files, reducing noise from IDE-specific files in project listings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 28, 2025

Walkthrough

Adds .vscode/ to .gitignore and inserts a TL;DR step in README.md advising users to install uv (suggesting brew install uv for macOS/Linux) before the existing setup steps.

Changes

Cohort / File(s) Summary
Configuration
\.gitignore
Adds .vscode/ entry under Misc to ignore VS Code workspace/settings; preserves surrounding blank line.
Documentation
README.md
Inserts a TL;DR step instructing users to ensure uv is installed, mentioning brew install uv for macOS/Linux, as a prerequisite before the existing workflow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Potential review focus:

  • \.gitignore: confirm placement and formatting (blank line preserved).
  • README.md: verify wording and the uv install link/command.

Poem

🐰 I hopped through the tree with a nimble shove,
Tucked .vscode/ out of sight with a shove,
Told friends to fetch uv before they start,
Tiny cleanups, a tidy heart. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "docs: adding install instructions for uv, and gitignore update for vs…" is clearly related to the main changes in the changeset. It accurately describes the two primary modifications: adding uv installation instructions to the README and updating the .gitignore file for VS Code. The title is concise and specific enough that a teammate scanning the history would understand the primary changes without needing to review the full diff.
Description Check ✅ Passed The pull request description follows the required template structure with all three main sections present: "Why?" (clarifying docs with uv brew installation instructions), "What Changed?" (addition to README and .gitignore update), and "Additional Notes" (with the checklist of pre-merge requirements). While the sections are somewhat minimal in detail, they provide the essential information needed to understand the changes. The description is mostly complete and adheres to the template format.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6234049 and 10f461c.

📒 Files selected for processing (1)
  • .gitignore (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .gitignore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 12fc545 and 581435c.

📒 Files selected for processing (2)
  • .gitignore (1 hunks)
  • README.md (1 hunks)
🔇 Additional comments (1)
.gitignore (1)

12-14: Good housekeeping. Adding .vscode/ to ignore IDE-generated artifacts is a best practice that prevents unnecessary files from being tracked.

Comment thread README.md Outdated
Comment thread README.md Outdated
thanks to a recommendation by Damien

Co-authored-by: Damien Storm <ryderstorm@users.noreply.github.com>
@ryderstorm
Copy link
Copy Markdown
Collaborator

@claude address the CI failure

@claude
Copy link
Copy Markdown

claude Bot commented Oct 30, 2025

Claude encountered an error —— View job

Failed with exit code 128

I'll analyze this and get back to you.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3c8f67 and 6234049.

📒 Files selected for processing (1)
  • .gitignore (1 hunks)
🔇 Additional comments (2)
.gitignore (2)

14-14: LGTM!

Adding .vscode/ to .gitignore is a standard best practice for excluding IDE-specific configuration files from version control.


1-14: File is correctly formatted—no issues detected.

The .gitignore file ends with a proper newline, has no trailing whitespace, and passes all standard formatting checks. Without actual CI logs, the speculated CI failure cannot be confirmed as related to these changes. The modifications are valid and correct.

Comment thread .gitignore Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
jguice added a commit that referenced this pull request Jan 10, 2026
Adds IDE workspace files to gitignore to prevent committing editor-specific configuration.

Credit to @djtjwillia from PR #24 for this contribution.

Co-Authored-By: Taylor Williams <taylorw@liatrio.com>
@jguice
Copy link
Copy Markdown
Contributor

jguice commented Jan 10, 2026

Hey @djtjwillia! 👋

Thank you for this contribution! We weren't able to rebase this branch, so we've incorporated your changes into a new PR:

#40 — includes your .vscode/ gitignore addition (with credit to you in the commit).

Regarding the uv install instructions — the README has been updated since this PR was opened and now includes that guidance. We've linked to the specific lines in #40 and asked if you could confirm it covers what you were adding.

Feel free to review and comment on #40 if you'd like any adjustments. Thanks again for helping improve the project! 🙏

@jguice jguice closed this Jan 10, 2026
jguice added a commit that referenced this pull request Jan 10, 2026
- Link directly to uv installation docs instead of main page
- Add concrete `brew install uv` command for macOS & Linux

Credit to @djtjwillia from PR #24 for this improvement.

Co-Authored-By: Taylor Williams <taylorw@liatrio.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants