Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/internal-packages/schema-bench/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"@liam-hq/neverthrow": "workspace:*",
"@liam-hq/schema": "workspace:*",
"dotenv": "16.5.0",
"langsmith": "0.3.73",
"langsmith": "0.5.18",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 pnpm-lock.yaml not updated after langsmith version bump

The package.json bumps langsmith from 0.3.73 to 0.5.18, but the pnpm-lock.yaml was not updated — it still references specifier: 0.3.73 for both the schema-bench and agent packages. Running pnpm install --frozen-lockfile (as CI typically does) will fail because the lockfile is out of sync with package.json. This is a major semver jump (0.3 → 0.5) that also likely involves breaking API changes to imports like evaluate from langsmith/evaluation, Client from langsmith, EvaluatorT from langsmith/evaluation, and Run/Example from langsmith/schemas (used in frontend/internal-packages/schema-bench/src/langsmith/schemaEvaluator.ts:2-3 and frontend/internal-packages/schema-bench/src/cli/evaluateWithLangsmith.ts:6).

Prompt for agents
The pnpm-lock.yaml file was not regenerated after bumping langsmith from 0.3.73 to 0.5.18 in frontend/internal-packages/schema-bench/package.json. This will cause CI failures when running pnpm install --frozen-lockfile. Run pnpm install to regenerate the lockfile and commit the updated pnpm-lock.yaml. Additionally, since this is a major version jump (0.3 to 0.5), verify that the langsmith API is still compatible with the current usage: evaluate from langsmith/evaluation, Client from langsmith, EvaluatorT from langsmith/evaluation, and Run/Example from langsmith/schemas (used in schemaEvaluator.ts and evaluateWithLangsmith.ts and uploadDatasetToLangsmith.ts). Check the langsmith changelog for breaking changes between 0.3 and 0.5.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"neverthrow": "8.2.0",
"openai": "5.9.2",
"tsx": "4.20.6",
Expand Down
Loading