Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/claude-pr-creator.yml
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Pre-existing: Direct interpolation of user-controlled content in prompt field

At .github/workflows/claude-pr-creator.yml:58-63, ${{ github.event.issue.title }} and ${{ github.event.issue.body }} are directly interpolated into the prompt YAML string without toJSON() wrapping. In contrast, the env block at lines 48-50 correctly uses toJSON() for the same values. While this isn't a shell injection (it's a YAML string input to an action, not a run: block), malicious issue content with special YAML characters could potentially break the YAML parsing or cause unexpected prompt content. This is a pre-existing concern unrelated to this PR's changes, and v1.0.29 of the action itself added mitigations for title-based injection vectors.

(Refers to lines 57-67)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
run: bash .github/scripts/setup-claude.sh

- name: Run Claude Code Action
uses: anthropics/claude-code-action@777ffcbfc9d2e2b07f3cfec41b7c7eadedd1f0dc # v1.0.12
uses: anthropics/claude-code-action@567fe954a4527e81f132d87d1bdbcc94f7737434 # v1.0.107
id: claude-code
env:
ISSUE_NUMBER: ${{ github.event.issue.number }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/claude.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
run: bash .github/scripts/setup-claude.sh

- name: Run Claude PR Action
uses: anthropics/claude-code-action@777ffcbfc9d2e2b07f3cfec41b7c7eadedd1f0dc # v1.0.12
uses: anthropics/claude-code-action@567fe954a4527e81f132d87d1bdbcc94f7737434 # v1.0.107
with:
anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
additional_permissions: |
Expand Down
Loading