Skip to content

Update dependency @ruby/prism to v1.4.0 #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025
Merged

Update dependency @ruby/prism to v1.4.0 #1221

merged 2 commits into from
Apr 11, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 8, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@​ruby/prism 1.2.0 -> 1.4.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner April 8, 2025 02:11
@renovate renovate bot requested review from hoshinotsuyoshi, FunamaYukina, junkisai, MH4GF and NoritakaIkeda and removed request for a team April 8, 2025 02:11
Copy link

vercel bot commented Apr 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liam-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 7:29am
liam-erd-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 7:29am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
liam-docs ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2025 7:29am

Copy link

changeset-bot bot commented Apr 8, 2025

🦋 Changeset detected

Latest commit: 22c06c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@liam-hq/db-structure Patch
@liam-hq/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

qodo-merge-pro-for-open-source bot commented Apr 8, 2025

CI Feedback 🧐

(Feedback updated until commit 2b0ddc2)

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: frontend-ci

Failed stage: Run pnpm test:turbo [❌]

Failure summary:

The action failed because the TypeScript compilation in the @liam-hq/db-structure package failed
with multiple type errors in the file src/parser/schemarb/parser.ts:

1. Multiple unused @ts-expect-error directives (lines 62, 76, 104, 114, 164, 188, 253, 255, 274,
315, 321, 328, 336)
2. Type error on line 212: "Argument of type 'Node' is not assignable to
parameter of type 'FalseNode | IntegerNode | StringNode | TrueNode'"

The build command failed with exit code 2, causing the entire workflow to fail.

Relevant error logs:
1:  ##[group]Operating System
2:  Ubuntu
...

159:  ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
160:  Progress: resolved 1896, reused 0, downloaded 109, added 103
161:  Progress: resolved 1896, reused 0, downloaded 235, added 225
162:  Progress: resolved 1896, reused 0, downloaded 403, added 399
163:  Progress: resolved 1896, reused 0, downloaded 517, added 509
164:  Progress: resolved 1896, reused 0, downloaded 522, added 516
165:  Progress: resolved 1896, reused 0, downloaded 629, added 620
166:  Progress: resolved 1896, reused 0, downloaded 843, added 838
167:  Progress: resolved 1896, reused 0, downloaded 943, added 948
168:  Progress: resolved 1896, reused 0, downloaded 1244, added 1258
169:  Progress: resolved 1896, reused 0, downloaded 1423, added 1433
170:  Progress: resolved 1896, reused 0, downloaded 1584, added 1598
171:  Progress: resolved 1896, reused 0, downloaded 1715, added 1723
172:  Progress: resolved 1896, reused 0, downloaded 1813, added 1815
173:  Progress: resolved 1896, reused 0, downloaded 1875, added 1896, done
174:  WARN  Failed to create bin at /home/runner/work/liam/liam/node_modules/.pnpm/node_modules/.bin/supabase. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/node_modules/.pnpm/node_modules/supabase/bin/supabase'
175:  .../node_modules/core-js-pure postinstall$ node -e "try{require('./postinstall')}catch(e){}"
176:  .../node_modules/@prisma/engines postinstall$ node scripts/postinstall.js
177:  .../node_modules/core-js-pure postinstall: Done
178:  .../node_modules/@biomejs/biome postinstall$ node scripts/postinstall.js
179:  .../[email protected]/node_modules/esbuild postinstall$ node install.js
180:  .../[email protected]/node_modules/sharp install$ node install/check
181:  .../node_modules/@biomejs/biome postinstall: Done
182:  .../[email protected]/node_modules/esbuild postinstall: Done
183:  .../node_modules/@sentry/cli postinstall$ node ./scripts/install.js
184:  .../node_modules/protobufjs postinstall$ node scripts/postinstall
185:  .../node_modules/@sentry/cli postinstall: Done
186:  .../node_modules/@prisma/engines postinstall$ node scripts/postinstall.js
187:  .../node_modules/protobufjs postinstall: Done
188:  .../[email protected]/node_modules/sharp install: Done
189:  WARN  Failed to create bin at /home/runner/work/liam/liam/node_modules/.pnpm/[email protected]/node_modules/supabase/node_modules/.bin/supabase. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/node_modules/.pnpm/[email protected]/node_modules/supabase/bin/supabase'
190:  .../node_modules/supabase postinstall$ node scripts/postinstall.js
...

246:  .../@playwright/browser-chromium install: FFMPEG playwright build v1011 downloaded to /home/runner/.cache/ms-playwright/ffmpeg-1011
247:  .../@playwright/browser-chromium install: Done
248:  .../node_modules/style-dictionary postinstall$ patch-package
249:  .../node_modules/prisma preinstall$ node scripts/preinstall-entry.js
250:  .../node_modules/prisma preinstall: Done
251:  .../node_modules/style-dictionary postinstall: patch-package 8.0.0
252:  .../node_modules/style-dictionary postinstall: Applying patches...
253:  .../node_modules/style-dictionary postinstall: No patch files found
254:  .../node_modules/style-dictionary postinstall: Done
255:  .../node_modules/@prisma/client postinstall$ node scripts/postinstall.js
256:  .../node_modules/@prisma/client postinstall: prisma:warn We could not find your Prisma schema in the default locations (see: https://pris.ly/d/prisma-schema-location).
257:  .../node_modules/@prisma/client postinstall: If you have a Prisma schema file in a custom path, you will need to run
258:  .../node_modules/@prisma/client postinstall: `prisma generate --schema=./path/to/your/schema.prisma` to generate Prisma Client.
259:  .../node_modules/@prisma/client postinstall: If you do not have a Prisma schema file yet, you can ignore this message.
260:  .../node_modules/@prisma/client postinstall: Done
261:  WARN  Failed to create bin at /home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/.bin/liam. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/frontend/packages/cli/dist-cli/bin/cli.js'
262:  devDependencies:
263:  + @changesets/cli 2.28.1
264:  + @changesets/get-github-info 0.6.0
265:  + @changesets/types 6.1.0
266:  + @turbo/gen 2.5.0
267:  + concurrently 9.1.2
268:  + syncpack 13.0.3
269:  + turbo 2.5.0
270:  + vercel 41.5.0
271:  frontend/apps/docs postinstall$ fumadocs-mdx
272:  frontend/apps/docs postinstall: [MDX] types generated
273:  frontend/apps/docs postinstall: Done
274:  frontend/apps/app postinstall$ cp ../../packages/db-structure/node_modules/@ruby/prism/src/prism.wasm prism.wasm
275:  frontend/apps/app postinstall: Done
276:  WARN  Failed to create bin at /home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/.bin/liam. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/@liam-hq/cli/dist-cli/bin/cli.js'
277:  Done in 25.2s using pnpm v9.15.9
...

731:  2b092e92b1a0: Verifying Checksum
732:  2b092e92b1a0: Download complete
733:  4f4fb700ef54: Verifying Checksum
734:  4f4fb700ef54: Download complete
735:  d261077062b2: Pull complete
736:  6bbeea27f58c: Verifying Checksum
737:  6bbeea27f58c: Download complete
738:  2babd04ec7b1: Pull complete
739:  6bbeea27f58c: Pull complete
740:  2b092e92b1a0: Pull complete
741:  9ced58d1ef15: Pull complete
742:  4f4fb700ef54: Pull complete
743:  Digest: sha256:4bc04aca94a44f04b427a490f346e7397ef7ce61fe589d718f744f7d92cb5c80
744:  Status: Downloaded newer image for public.ecr.aws/supabase/vector:0.28.1-alpine
745:  2.8.1: Pulling from supabase/kong
746:  failed to display json stream: toomanyrequests: Rate exceeded
747:  Retrying after 4s: public.ecr.aws/supabase/kong:2.8.1
...

1021:  cache miss, executing 810ad8d1a975bc3e
1022:  > @liam-hq/[email protected] gen /home/runner/work/liam/liam/frontend/packages/erd-core
1023:  > concurrently "pnpm:gen:*"
1024:  [css] 
1025:  [css] > @liam-hq/[email protected] gen:css /home/runner/work/liam/liam/frontend/packages/erd-core
1026:  [css] > tcm src
1027:  [css] 
1028:  [css] Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/styles/variables.css.d.ts
1029:  [css] Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/styles/globals.css.d.ts
1030:  [css] Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/features/erd/components/ERDRenderer/ERDRenderer.module.css.d.ts
1031:  [css] Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/features/erd/components/ERDContent/ERDContent.module.css.d.ts
1032:  [css] Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/features/erd/components/ERDRenderer/Toolbar/DesktopToolbar.module.css.d.ts
1033:  [css] Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/features/erd/components/ERDRenderer/TableDetailDrawer/TableDetailDrawer.module.css.d.ts
1034:  [css] Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/features/erd/components/ERDRenderer/RelationshipEdgeParticleMarker/RelationshipEdgeParticleMarker.module.css.d.ts
1035:  [css] Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/features/erd/components/ERDRenderer/LeftPane/LeftPane.module.css.d.ts
1036:  [css] Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/features/erd/components/ERDRenderer/ErrorDisplay/ParseErrorDisplay.module.css.d.ts
1037:  [css] Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/features/erd/components/ERDRenderer/ErrorDisplay/NetworkErrorDisplay.module.css.d.ts
1038:  [css] Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/features/erd/components/ERDRenderer/ErrorDisplay/ErrorDisplay.module.css.d.ts
1039:  [css] Wrote /home/runner/work/liam/liam/frontend/packages/erd-core/src/features/erd/components/ERDRenderer/CardinalityMarkers/CardinalityMarkers.module.css.d.ts
...

1095:  > concurrently "pnpm:gen:*"
1096:  [css] 
1097:  [css] > @liam-hq/[email protected] gen:css /home/runner/work/liam/liam/frontend/apps/app
1098:  [css] > tcm components
1099:  [css] 
1100:  [css] Wrote /home/runner/work/liam/liam/frontend/apps/app/components/UserFeedbackComponent.module.css.d.ts
1101:  [css] Wrote /home/runner/work/liam/liam/frontend/apps/app/components/CopyButton/CopyButton.module.css.d.ts
1102:  [css] Wrote /home/runner/work/liam/liam/frontend/apps/app/components/CookieConsent/CookieConsent.module.css.d.ts
1103:  [css] Wrote /home/runner/work/liam/liam/frontend/apps/app/components/CommonLayout/CommonLayout.module.css.d.ts
1104:  [css] pnpm run gen:css exited with code 0
1105:  ##[endgroup]
1106:  �[;31m@liam-hq/db-structure:build�[;0m
1107:  cache miss, executing 26183477cf1ee08d
1108:  > @liam-hq/[email protected] build /home/runner/work/liam/liam/frontend/packages/db-structure
1109:  > tsc && pnpm run cp:prism
1110:  ##[error]src/parser/schemarb/parser.ts(62,3): error TS2578: Unused '@ts-expect-error' directive.
1111:  ##[error]src/parser/schemarb/parser.ts(76,9): error TS2578: Unused '@ts-expect-error' directive.
1112:  ##[error]src/parser/schemarb/parser.ts(104,9): error TS2578: Unused '@ts-expect-error' directive.
1113:  ##[error]src/parser/schemarb/parser.ts(114,9): error TS2578: Unused '@ts-expect-error' directive.
1114:  ##[error]src/parser/schemarb/parser.ts(164,7): error TS2578: Unused '@ts-expect-error' directive.
1115:  ##[error]src/parser/schemarb/parser.ts(188,11): error TS2578: Unused '@ts-expect-error' directive.
1116:  ##[error]src/parser/schemarb/parser.ts(212,46): error TS2345: Argument of type 'Node' is not assignable to parameter of type 'FalseNode | IntegerNode | StringNode | TrueNode'.
1117:  Type 'AliasGlobalVariableNode' is not assignable to type 'FalseNode | IntegerNode | StringNode | TrueNode'.
1118:  Type 'AliasGlobalVariableNode' is not assignable to type 'TrueNode'.
1119:  Property '#private' in type 'AliasGlobalVariableNode' refers to a different member that cannot be accessed from within type 'TrueNode'.
1120:  ##[error]src/parser/schemarb/parser.ts(253,3): error TS2578: Unused '@ts-expect-error' directive.
1121:  ##[error]src/parser/schemarb/parser.ts(255,3): error TS2578: Unused '@ts-expect-error' directive.
1122:  ##[error]src/parser/schemarb/parser.ts(274,7): error TS2578: Unused '@ts-expect-error' directive.
1123:  ##[error]src/parser/schemarb/parser.ts(315,15): error TS2578: Unused '@ts-expect-error' directive.
1124:  ##[error]src/parser/schemarb/parser.ts(321,15): error TS2578: Unused '@ts-expect-error' directive.
1125:  ##[error]src/parser/schemarb/parser.ts(328,17): error TS2578: Unused '@ts-expect-error' directive.
1126:  ##[error]src/parser/schemarb/parser.ts(336,17): error TS2578: Unused '@ts-expect-error' directive.
1127:  ELIFECYCLE  Command failed with exit code 2.
1128:  [ERROR] command finished with error: command (/home/runner/work/liam/liam/frontend/packages/db-structure) /home/runner/setup-pnpm/node_modules/.bin/pnpm run build exited (2)
1129:  ##[group]@liam-hq/db-structure:test
...

1133:  �[1m�[7m�[36m RUN �[39m�[27m�[22m �[36mv3.1.1 �[39m�[90m/home/runner/work/liam/liam/frontend/packages/db-structure�[39m
1134:  �[32m✓�[39m src/parser/tbls/index.test.ts �[2m(�[22m�[2m20 tests�[22m�[2m)�[22m�[32m 61�[2mms�[22m�[39m
1135:  (node:7925) ExperimentalWarning: WASI is an experimental feature and might change at any time
1136:  (Use `node --trace-warnings ...` to show where the warning was created)
1137:  �[32m✓�[39m src/parser/prisma/index.test.ts �[2m(�[22m�[2m20 tests�[22m�[2m)�[22m�[33m 385�[2mms�[22m�[39m
1138:  �[32m✓�[39m src/parser/schemarb/index.test.ts �[2m(�[22m�[2m18 tests�[22m�[2m)�[22m�[33m 637�[2mms�[22m�[39m
1139:  �[32m✓�[39m src/schema/overrideDbStructure.test.ts �[2m(�[22m�[2m6 tests�[22m�[2m)�[22m�[32m 30�[2mms�[22m�[39m
1140:  �[32m✓�[39m src/parser/sql/postgresql/processSQLInChunks.test.ts �[2m(�[22m�[2m6 tests�[22m�[2m)�[22m�[32m 14�[2mms�[22m�[39m
1141:  �[32m✓�[39m src/parser/tbls/schema.generated.test.ts �[2m(�[22m�[2m5 tests�[22m�[2m)�[22m�[32m 39�[2mms�[22m�[39m
1142:  �[32m✓�[39m src/parser/schemarb/singularize.test.ts �[2m(�[22m�[2m18 tests�[22m�[2m)�[22m�[32m 18�[2mms�[22m�[39m
1143:  �[32m✓�[39m src/parser/supportedFormat/detectFormat.test.ts �[2m(�[22m�[2m10 tests�[22m�[2m)�[22m�[32m 15�[2mms�[22m�[39m
1144:  (node:8173) ExperimentalWarning: WASI is an experimental feature and might change at any time
1145:  (Use `node --trace-warnings ...` to show where the warning was created)
1146:  �[32m✓�[39m src/parser/index.test.ts �[2m(�[22m�[2m2 tests�[22m�[2m)�[22m�[32m 231�[2mms�[22m�[39m
1147:  ##[endgroup]
1148:  ##[error]@liam-hq/db-structure#build: command (/home/runner/work/liam/liam/frontend/packages/db-structure) /home/runner/setup-pnpm/node_modules/.bin/pnpm run build exited (2)
1149:  Tasks:    8 successful, 10 total
1150:  Cached:    0 cached, 10 total
1151:  Time:    13.135s 
1152:  Failed:    @liam-hq/db-structure#build
1153:  ERROR  run failed: command  exited (2)
1154:  ELIFECYCLE  Command failed with exit code 2.
1155:  ##[error]Process completed with exit code 2.
1156:  Post job cleanup.

@hoshinotsuyoshi
Copy link
Member

👀

https://github.com/liam-hq/liam/actions/runs/14323556350/job/40144898447?pr=1221

@liam-hq/db-structure:build
cache miss, executing 96d0da1bda923c8e

> @liam-hq/[email protected] build /home/runner/work/liam/liam/frontend/packages/db-structure
> tsc && pnpm run cp:prism

Error: src/parser/schemarb/parser.ts(62,3): error TS2578: Unused '@ts-expect-error' directive.
Error: src/parser/schemarb/parser.ts(76,9): error TS2578: Unused '@ts-expect-error' directive.
Error: src/parser/schemarb/parser.ts(104,9): error TS2578: Unused '@ts-expect-error' directive.
Error: src/parser/schemarb/parser.ts(114,9): error TS2578: Unused '@ts-expect-error' directive.
Error: src/parser/schemarb/parser.ts(164,7): error TS2578: Unused '@ts-expect-error' directive.
Error: src/parser/schemarb/parser.ts(188,11): error TS2578: Unused '@ts-expect-error' directive.
Error: src/parser/schemarb/parser.ts(212,46): error TS2345: Argument of type 'Node' is not assignable to parameter of type 'FalseNode | IntegerNode | StringNode | TrueNode'.
  Type 'AliasGlobalVariableNode' is not assignable to type 'FalseNode | IntegerNode | StringNode | TrueNode'.
    Type 'AliasGlobalVariableNode' is not assignable to type 'TrueNode'.
      Property '#private' in type 'AliasGlobalVariableNode' refers to a different member that cannot be accessed from within type 'TrueNode'.
Error: src/parser/schemarb/parser.ts(253,3): error TS2578: Unused '@ts-expect-error' directive.
Error: src/parser/schemarb/parser.ts(255,3): error TS2578: Unused '@ts-expect-error' directive.
Error: src/parser/schemarb/parser.ts(274,7): error TS2578: Unused '@ts-expect-error' directive.
Error: src/parser/schemarb/parser.ts(313,15): error TS2578: Unused '@ts-expect-error' directive.
Error: src/parser/schemarb/parser.ts(319,15): error TS2578: Unused '@ts-expect-error' directive.
Error: src/parser/schemarb/parser.ts(326,17): error TS2578: Unused '@ts-expect-error' directive.
Error: src/parser/schemarb/parser.ts(334,17): error TS2578: Unused '@ts-expect-error' directive.
 ELIFECYCLE  Command failed with exit code 2.
Error:  command finished with error: command (/home/runner/work/liam/liam/frontend/packages/db-structure) /home/runner/setup-pnpm/node_modules/.bin/pnpm run build exited (2)
@liam-hq/db-structure:test

 Tasks:    8 successful, 10 total
Cached:    0 cached, 10 total
  Time:    12.709s 
Failed:    @liam-hq/db-structure#build

 ERROR  run failed: command  exited (2)
 ELIFECYCLE  Command failed with exit code 2.
Error: Process completed with exit code 2.

@hoshinotsuyoshi hoshinotsuyoshi self-assigned this Apr 9, 2025
@hoshinotsuyoshi
Copy link
Member

Added a commit for CI

@hoshinotsuyoshi
Copy link
Member

I handcrafted this commit myself: b41f68c – would appreciate a review from someone else! @liam-hq/liam-dev

@hoshinotsuyoshi
Copy link
Member

And .changset for db-structure needed ? 💭

@renovate renovate bot force-pushed the renovate/ruby-prism-1.x branch from b41f68c to 2b0ddc2 Compare April 11, 2025 07:20
@renovate renovate bot changed the title fix(deps): update dependency @ruby/prism to v1.4.0 Update dependency @ruby/prism to v1.4.0 Apr 11, 2025
Copy link
Contributor Author

renovate bot commented Apr 11, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@hoshinotsuyoshi
Copy link
Member

Comment on lines -212 to +213
column.default = extractDefaultValue(value)
if (
value instanceof TrueNode ||
value instanceof FalseNode ||
value instanceof StringNode ||
value instanceof IntegerNode
) {
column.default = extractDefaultValue(value)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was needed since value is a Node, which doesn’t match the argument type expected by extractDefaultValue.

Copy link
Member

@MH4GF MH4GF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the schema-rb parser is fine as I have written the tests well. Thanks!

@@ -59,7 +59,6 @@ function extractTableName(
)
}

// @ts-expect-error: unescaped is defined as string but it is actually object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the library fixed it 👍🏻

@MH4GF MH4GF added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit 917d235 Apr 11, 2025
17 of 18 checks passed
@MH4GF MH4GF deleted the renovate/ruby-prism-1.x branch April 11, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants