-
Notifications
You must be signed in to change notification settings - Fork 122
Update dependency @ruby/prism to v1.4.0 #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: 22c06c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CI Feedback 🧐(Feedback updated until commit 2b0ddc2)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
👀 https://github.com/liam-hq/liam/actions/runs/14323556350/job/40144898447?pr=1221
|
Added a commit for CI |
a9841ac
to
ab515a0
Compare
I handcrafted this commit myself: b41f68c – would appreciate a review from someone else! @liam-hq/liam-dev |
And .changset for |
b41f68c
to
2b0ddc2
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
tested: https://liam-erd-sample-git-renovate-ruby-prism-1x-route-06-core.vercel.app/ (mastodon, ruby) works. |
column.default = extractDefaultValue(value) | ||
if ( | ||
value instanceof TrueNode || | ||
value instanceof FalseNode || | ||
value instanceof StringNode || | ||
value instanceof IntegerNode | ||
) { | ||
column.default = extractDefaultValue(value) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was needed since value
is a Node
, which doesn’t match the argument type expected by extractDefaultValue
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the schema-rb parser is fine as I have written the tests well. Thanks!
@@ -59,7 +59,6 @@ function extractTableName( | |||
) | |||
} | |||
|
|||
// @ts-expect-error: unescaped is defined as string but it is actually object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the library fixed it 👍🏻
This PR contains the following updates:
1.2.0
->1.4.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.