Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow more than one candidate backends #1441

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lifeiteng
Copy link
Contributor

No description provided.

@pzelasko
Copy link
Collaborator

Can you elaborate why is this change needed?

@lifeiteng
Copy link
Contributor Author

I want to try use different backends for opus: export LHOTSE_LEGACY_OPUS_LOADING=1 will have two backends (ffmpeg + soundfile).

@pzelasko
Copy link
Collaborator

pzelasko commented Jan 3, 2025

Could you instead remove the condition in lines 514-515 in lhotse/audio/backend.py?

if isinstance(path_or_fd, (Path, str)) and str(path_or_fd).endswith(".opus"):
return True # use libnsdfile for OPUS

@lifeiteng
Copy link
Contributor Author

Could you instead remove the condition in lines 514-515 in lhotse/audio/backend.py?

if isinstance(path_or_fd, (Path, str)) and str(path_or_fd).endswith(".opus"):
return True # use libnsdfile for OPUS

done

@pzelasko
Copy link
Collaborator

pzelasko commented Jan 4, 2025

Thanks, I meant to also revert the change removing the check for unique backends - I think it is useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants