Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Developing LHCb Software to use git #197

Merged
merged 3 commits into from
Nov 29, 2016
Merged

Conversation

pikacic
Copy link
Contributor

@pikacic pikacic commented Nov 25, 2016

See #182

@@ -192,10 +192,10 @@ functors](06-loki-functors.html)!
> For example, to explore the `DST` we could have simply done:
>
> ```
> lb-run Bender bender 00035742_00000002_1.allstreams.dst
> lb-run Bender/latest bender 00035742_00000002_1.allstreams.dst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this /latest, but when specifying a version it's with a space?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually Project/version works always (I forgot to update the --help message when I added the feature to lb-run).

The syntax with a space works only for "standard" versions (vXrY, latest), but not with more original versions (master, upgradeTracking) that you may find in the nightly builds.

At some point I'll drop the syntax with a space... in a far future.

About this specific line, there's a difference between lb-run and SetupProject: when you do not specify the version SetupProject uses latest, while lb-run uses prod which is almost never defined (in which case lb-run falls back on SetupProject). What is really wanted here is lb-run Bender/latest <command> and not lb-run Bender <command>.

One more note: LHCbDirac does have a defined prod version, so lb-run LHCbDirac <command> works correctly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would be better to always use Project/version then?

@pikacic
Copy link
Contributor Author

pikacic commented Nov 28, 2016

I just rebased on the the current master.

I thought of merging stuff from second-analysis-steps/02-lb-git.md, but I'm not that convinced anymore. This is a lightweight introduction to satellite projects, and the other is more targeted to developers.

@ibab
Copy link
Contributor

ibab commented Nov 29, 2016

Yes, I agree with that.
Everything looks good, so I'm merging now.

@ibab ibab merged commit 73dae5b into lhcb:master Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants