new sample ws chat completion and bug fix#92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on repository hygiene and dead code cleanup, as well as improvements to the build and release process and documentation. The main changes include removing unused dependencies, updating the release workflow to simplify and clarify build outputs, adding support for new WASM-JS samples, and improving documentation for SDK usage, protocol conventions, and local path dependencies.
Dead code cleanup and dependency management:
tonic-webfromCargo.toml.spear-ssfinCargo.tomland updated Dockerfiles to copy this crate into the build context, with documentation updates explaining this requirement. [1] [2] [3] [4] [5] [6]Build and release workflow improvements:
target/release/spearlet,target/release/sms). [1] [2]WASM-JS samples and Makefile:
router_filter_keyword,user_stream_echo,user_stream_chat_completion) to the build system and documentation, and updated sample output naming conventions. [1] [2] [3] [4] [5] [6] [7] [8]Protocol and SDK documentation:
CTRL(1),DATA(2), andCOMMIT(3) message types, and documented SDK constants for C, Rust, and JS. [1] [2] [3]Minor code cleanup:
These changes collectively improve maintainability, reduce build complexity, and provide clearer guidance for contributors and users.