*Enabled -Werror=switch-enum for evse_security_conversions targt * Ad…

…ded missing enum value conversion for CertificateValidationResult Signed-off-by: Piet Gömpel <[email protected]>
lf-energy-projects-renovation-state · Feb 25, 2025 · d49814c · d49814c
1 parent dd7c1eb
commit d49814c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/staging/evse_security/CMakeLists.txt b/lib/staging/evse_security/CMakeLists.txt
@@ -13,10 +13,17 @@ target_include_directories(evse_security_conversions
     "$<TARGET_PROPERTY:generate_cpp_files,EVEREST_GENERATED_INCLUDE_DIR>"
 )
 
+target_compile_options(evse_security_conversions
+    PRIVATE
+        -Wimplicit-fallthrough
+        -Werror=switch-enum
+)
+
 add_dependencies(evse_security_conversions generate_cpp_files)
 
 target_link_libraries(evse_security_conversions
     PRIVATE
         everest::evse_security
         everest::framework
 )
+
diff --git a/lib/staging/evse_security/conversions.cpp b/lib/staging/evse_security/conversions.cpp
@@ -328,9 +328,10 @@ types::evse_security::CertificateValidationResult to_everest(evse_security::Cert
         return types::evse_security::CertificateValidationResult::InvalidLeafSignature;
     case evse_security::CertificateValidationResult::InvalidChain:
         return types::evse_security::CertificateValidationResult::InvalidChain;
+    case evse_security::CertificateValidationResult::Expired:
+        return types::evse_security::CertificateValidationResult::Expired;
     case evse_security::CertificateValidationResult::Unknown:
         return types::evse_security::CertificateValidationResult::Unknown;
-        ;
     default:
         throw std::runtime_error("Could not convert evse_security::CertificateValidationResult to "
                                  "types::evse_security::CertificateValidationResult");