Fix locale inconsistencies and German survey launch#810
Fix locale inconsistencies and German survey launch#810
Conversation
|
Visit the preview URL for this PR (updated for commit 02fc40b): https://hs-levante-admin-dev--pr810-fix-full-language-co-muyup727.web.app (expires Thu, 19 Feb 2026 15:59:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7889bff1da3bcc333d7422b9fc863c65b3962be7 |
digital-pro
left a comment
There was a problem hiding this comment.
I think the code itself is fine. I wyorry about two things:
- Existing users with locale either en or de, and making sure they migrate gracefully.
- Task audio is stored under en and de, so some combination of @CCuskley and @zwatson2001 need to decide if it will still work. We should almost certainly rename those folders (like we did es to es-CO), but that will in turn require some updates to _translations.
I think the new findBestMatchingLocale() helper should resolve the first problem: if a user has a locale like en, it will resolve to en-US; de will resolve to de-DE. This is generalised so e.g., es falls back to es-CO; when pt-BR comes, pt-PT would resolve to pt-BR etc etc. Basically if it's only a two letter code it looks for the best match. But that's only dashboard side - I think this shouldn't affect tasks themselves because the variant sets the language code, but will confirm with @zwatson2001. Even if it does set the language code separately, we want to make sure it matches the dashbaord one. |
Proposed changes
Types of changes
What types of changes does this pull request introduce?
Additional Notes