Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UI improvements #326

Merged
merged 15 commits into from
Dec 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
node_modules
dist
vue.config.js
knip.ts
10 changes: 10 additions & 0 deletions .github/workflows/check-source-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,16 @@ jobs:
- name: Build source code
run: npm run build

knip-checkup:
name: No unused files and exports
needs: prepare-dependencies
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/prepare-local-env
- name: Run knip
run: npm run knip

# integration-tests:
# name: Integration testing
# needs: prepare-dependencies
Expand Down
55 changes: 55 additions & 0 deletions knip.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
// eslint-disable-next-line import/no-self-import
import type { KnipConfig } from "knip";

const config: KnipConfig = {
ignore: [
".eslintrc.js",
"index.d.ts",
"vite.config.js",
"backend/**/**",
"wallaby.js",
// keep it for now, delete when Playwright added
"tests/**/**",
"cypress/**/**",
// keep them all for now
"src/components/lib/**/**",
// for some reason it cannot resolve it
"tsconfig.json",
],
ignoreDependencies: [
// Needed for Storybook
"react-dom",
// Storybook
"@storybook/cli",
"@storybook/theming",
"@storybook/vue3",
"@storybook/addon-docs",
"@storybook/addon-actions",
// needed on CI
"shared-types",
],
// ignoreBinaries: ["eslint"],
rules: {
// Disables "Dubplicate exports" warning. In some components we want to keep
// exporting the component both as the variable and as a "default export"
duplicates: "off",
// enumMembers: "off",
},

/**
* PLUGINS
*
* We define them manually, because Knip cannot find them automatically.
* We need them defined, so Knip won't report of unused dependencies and will
* respect plugins configs.
*/
eslint: {
config: [".eslintrc", ".eslintrc.cjs"],
entry: [".eslintrc.cjs"],
},
/**
* PLUGINS END
*/
};

export default config;
Loading
Loading