-
-
Notifications
You must be signed in to change notification settings - Fork 804
Replace parking_lot locks with std locks #4410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks; I found the same binary size effect and removed all the The house style is to use |
|
Has anyone read this? https://blog.cuongle.dev/p/inside-rusts-std-and-parking-lot-mutexes-who-win Not sure what the lock contention is like for a typical leptos app to gauge the better choice here or what proportion of locking is happening in wasm vs the server (when using SSR) where thread contention actually matters |
|
There should be effectively zero lock contention for the cases covered by this PR. In the |
Based on #4408, it needs to be merged first.
Shouldn't have any effects on size and performance from the usage.
Reduced wasm bundle size by 5% on my production project.