Adding automatic PR creation for generated README.md & installers.toml #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heshdude
force-pushed
the
improving-automation
branch
from
5502849 to
880fe52
Compare
With out the / this gets installers.toml also
agentmilindu
requested review from
tharindupr,
agentmilindu,
rehrumesh and
tdevinda
agentmilindu
reviewed
Aug 9, 2020
| run: | | ||
| pip install toml pytablewriter | ||
| python generate.py ${{ env.GIT_DIFF }} | ||
| docker build -t shellspec . |
There was a problem hiding this comment.
Let's move this Docker image to GitHub Packages and put up a GitHub Action to build it and push. We can simply pull the image here.
There was a problem hiding this comment.
Let's take this into this week #59
agentmilindu
approved these changes
Aug 9, 2020
agentmilindu
added a commit
that referenced
this pull request
Aug 10, 2020
…rs-toml-69 Update installer scripts, README.md & installers.toml for #69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the Continuous Delivery part of the installers completes. Now when a someone creates a PR with a new
installer.tomlfile for a tool and gets it merged, the GitHub Actions will generate theinstaller.sh,installer.min.shthen updates theREADME.mdandinstallers.tomlwith a summary.Sample PR from someone: Heshdude#43 ( only
installer.tomlfile )Auto generated PR: Heshdude#44 (
installer.sh,installer.min.sh,README.mdandinstallers.toml)