Add if on edge, bounce #59
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adroitwhiz
reviewed
Mar 18, 2020
PullJosh
requested changes
Mar 21, 2020
PullJosh
approved these changes
Mar 27, 2020
There was a problem hiding this comment.
I just tried this out and am getting some weird behavior. :P
Also, something that isn't very well documented (my fault!) is that code should be formatted using Prettier. If you install the Prettier extension for your code editor of choice, things will be auto-formatted for you perfectly every time you save a file.
PullJosh
requested changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
if on edge, bounce(and of course touching edge), available asthis.ifOnEdgeBounce()andthis.touchingEdge().