fix: resolve lint issues and remove unused deprecated functions#7
Merged
Conversation
- Remove 9 unused deprecated functions from cmd/check.go - Fix deprecated comment format (add blank line before Deprecated notices) - Fix line length issues by breaking long function signatures - Use max() builtin instead of if statement in parser.go - Add nolint directive for xml package naming (matches file type)
- Remove Validate and Parse methods from FileParser interface - Keep only ValidateAndParse as the single method for parsing - Remove deprecated functions from all parser implementations - Remove FindMarkdownFiles from scanner (use FindFiles instead) - Remove ScanFilesCmdWithPath and ExtractLinksCmd from UI commands - Update all tests to use ValidateAndParse - Consolidate benchmark tests to single ValidateAndParse benchmark This simplifies the API and removes ~360 lines of deprecated code.
leonardomso
force-pushed
the
fix/lint-and-test-issues
branch
from
711e90f to
d5ad068
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmd/check.gothat were replaced by V2/WithConfig versionsDeprecated:notices (gocritic)max()builtin instead of if statement inparser.go(modernize)Changes
cmd/check.gocmd/interactive.gointernal/ui/app.gointernal/parser/*.gointernal/parser/parser.gomax()builtininternal/parser/xml/*.goTesting
go test ./...golangci-lint run ./...go build ./...