Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extrinsic] fix extrinsic codec for AssetHubExtensions #401

Conversation

clangenb
Copy link
Contributor

I am implementing in a naive way our custom signed extensions, and while doing that I noticed that the asset hub signed extensions didn't work. This PR fixes that. I am doing this in the quick way because I know that you are implementing #359, which will probably change this part of the code anyhow.

@clangenb clangenb marked this pull request as draft January 26, 2024 12:32
@clangenb clangenb marked this pull request as ready for review January 26, 2024 13:17
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (6929fc8) 46.98% compared to head (2a3d552) 46.91%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
- Coverage   46.98%   46.91%   -0.07%     
==========================================
  Files         164      164              
  Lines        8914     8926      +12     
==========================================
  Hits         4188     4188              
- Misses       4726     4738      +12     
Flag Coverage Δ
polkadart 16.85% <0.00%> (-0.17%) ⬇️
polkadart_cli 12.05% <ø> (ø)
polkadart_keyring 77.24% <ø> (ø)
polkadart_scale_codec 54.93% <ø> (ø)
sr25519 85.91% <ø> (ø)
ss58 96.87% <ø> (ø)
substrate_bip39 63.35% <ø> (ø)
substrate_metadata 87.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ges/polkadart/lib/extrinsic/extrinsic_payload.dart 0.00% <0.00%> (ø)
...kages/polkadart/lib/extrinsic/signing_payload.dart 0.00% <0.00%> (ø)

@leonardocustodio leonardocustodio self-assigned this Jan 26, 2024
@leonardocustodio leonardocustodio merged commit ca49c1b into leonardocustodio:main Jan 26, 2024
11 checks passed
@clangenb clangenb deleted the pr/fix-asset-hub-signed-extensions branch January 27, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants