security: reject unissued csrf tokens#1660
Open
saurabhhhcodes wants to merge 2 commits into
Open
Conversation
|
🎉 Welcome to Hybrid Recommender, @saurabhhhcodes! This is your first contribution here! Labels added: PR Description Checklist: ✅ PR description looks complete! What happens next:
⏱️ Please respond to review comments within 48 hours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1657.
What changed
backend/csrf.pyso CSRF validation only accepts tokens minted by the app.Why
Double-submit cookie protection should not accept an arbitrary matching token pair. This change closes the token-injection path described in the issue by requiring server issuance before a token can be used.
How to test
python3 -m py_compile backend/csrf.py tests/test_csrf.pyValidation
python3 -m py_compile backend/csrf.py tests/test_csrf.pyTestClientgit diff --check