fix: enforce stronger signup password validation#1655
Open
saurabhhhcodes wants to merge 3 commits into
Open
Conversation
|
🎉 Welcome to Hybrid Recommender, @saurabhhhcodes! This is your first contribution here! Labels added: PR Description Checklist: What happens next:
⏱️ Please respond to review comments within 48 hours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1634.
What changed
frontend/js/auth.jsbefore signup calls are sent to Supabase.frontend/index.htmlto match the stronger policy.Why
The live frontend flow uses
frontend/js/auth.jsrather than theregister.jspath mentioned in the issue. This change blocks weak signup attempts earlier and keeps the password policy clear for users.How to test
node --check frontend/js/auth.jspassword123.Validation
node --check frontend/js/auth.jsgit diff --checkNotes
This is a frontend-side guard that complements the hosted auth provider and avoids sending obviously weak passwords through the signup flow.