Skip to content

build: add faiss dependency for two-tower retrieval#1654

Open
saurabhhhcodes wants to merge 2 commits into
leonagoel:mainfrom
saurabhhhcodes:fix/faiss-dependency
Open

build: add faiss dependency for two-tower retrieval#1654
saurabhhhcodes wants to merge 2 commits into
leonagoel:mainfrom
saurabhhhcodes:fix/faiss-dependency

Conversation

@saurabhhhcodes

Copy link
Copy Markdown

Summary

Fixes #1630.

What changed

  • Added faiss-cpu>=1.8.0 to requirements.txt so the two-tower retrieval engine can import faiss during test collection and runtime setup.

Validation

  • git diff --check
  • Verified the dependency entry is present in requirements.txt

Notes

This branch is stacked on top of the recommendation route cleanup branch so the dependency lane can keep moving without waiting on that review to land.

@github-actions

Copy link
Copy Markdown

🎉 Welcome to Hybrid Recommender, @saurabhhhcodes! This is your first contribution here!

Labels added: gssoc:approved | mentor:leonagoel | status:review-needed

PR Description Checklist:

YES - What changed section
NO - Why section
NO - How to test section
YES - Related issue linked

⚠️ Some required sections are missing. Please update your PR description.

What happens next:

  1. @leonagoel will review your changes
  2. CI checks must pass
  3. Once approved, this PR will be auto-merged

⏱️ Please respond to review comments within 48 hours.

@github-actions github-actions Bot requested a review from leonagoel June 14, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: Missing 'faiss' dependency in requirements.txt

2 participants