Fix wishlist link to point at the actual page#1651
Draft
saurabhhhcodes wants to merge 2 commits into
Draft
Conversation
🎉 Welcome to Hybrid Recommender, @saurabhhhcodes!Thank you for your first pull request! Here's what happens next:
⏱️ Please respond to any review comments within 48 hours. 📖 Resources: Happy contributing! 🚀 |
|
🎉 Welcome to Hybrid Recommender, @saurabhhhcodes! This is your first contribution here! Labels added: PR Description Checklist: What happens next:
⏱️ Please respond to review comments within 48 hours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
frontend/index.htmlto point at the actual sibling page (./wishlist.html) instead of the non-functional static path.Why
The wishlist page already exists in the frontend bundle, but the old link pointed at a path that does not match the repo layout. This made the shortcut look real while sending users to the wrong place.
Validation
git diff --checkcurl -I http://127.0.0.1:8123/wishlist.htmlreturned200 OKfrontend/index.htmlnow renders./wishlist.htmlCloses #1638