Add support for controlling entity settings visibility during runtime#7816
Add support for controlling entity settings visibility during runtime#7816
Conversation
Signed-off-by: Juho Heikka <juho.heikka@gmail.com>
jweak
requested review from
a team,
Iku-turso and
gabriel-mirantis
and removed request for
a team
| components: EntitySettingComponents; | ||
| source?: string; | ||
| group: string; | ||
| isShown: IComputedValue<boolean>; |
There was a problem hiding this comment.
Why not call this also visible?
There was a problem hiding this comment.
I tried to replicate the existing behavior that was implemented with AppPreferenceTabRegistration. I think it's a convention in this code base for Showable and such
| components: EntitySettingComponents; | ||
| source?: string; | ||
| group: string; | ||
| isShown: IComputedValue<boolean>; |
There was a problem hiding this comment.
I wonder if this should be optional to not break something..
There was a problem hiding this comment.
The EntitySettingRegistration from extension has optional visible. When the extension settings are read the extension settings are converted to RegisteredEntitySetting and then we can make this not optional which is nicer for the users of RegisteredEntitySetting. We default to visible then if the visible property is not set
Nokel81
left a comment
Nokel81
left a comment
There was a problem hiding this comment.
Could we get a unit test showing that this implementation is working please?
|
Also this is an enhancement, it should not go against a patch release @jweak |
Okay I'm not that familiar how the milestones work. There's a high prio bug in an extension that needs this though. |
|
oh okay I see, sure |
Signed-off-by: Juho Heikka <juho.heikka@gmail.com>
Good point! Added unit tests. |
3 participants
Extension might want to control visibility of entity settings during runtime. This change adds this ability. Has the same logic than earlier implementation for
AppPreferenceTabRegistrationResolves #7815