Skip to content

Plot for the minimizer of the new ctc correction - #56

Draft
DaGeibl wants to merge 2 commits into
legend-exp:mainfrom
DaGeibl:lq_ctc
Draft

Plot for the minimizer of the new ctc correction#56
DaGeibl wants to merge 2 commits into
legend-exp:mainfrom
DaGeibl:lq_ctc

Conversation

@DaGeibl

@DaGeibl DaGeibl commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

This Pull Requests adds a recipe for the new lq_ctc function. The plot takes a named tuple with information about the optimizer, calculates sigmas for different correction paramters, and plots the optimal parameter that was found. The plot looks like this:

image

@codecov

codecov Bot commented Sep 15, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 14.92537% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.36%. Comparing base (8d817d8) to head (af31f25).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
ext/LegendMakieLegendSpecFitsExt.jl 14.92% 57 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   99.72%   91.36%   -8.36%     
==========================================
  Files           9        9              
  Lines         722      799      +77     
==========================================
+ Hits          720      730      +10     
- Misses          2       69      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@theHenks
theHenks requested review from fhagemann and theHenks and removed request for theHenks October 10, 2025 13:48
@theHenks theHenks self-assigned this Oct 10, 2025
@theHenks
theHenks requested review from theHenks and removed request for fhagemann October 10, 2025 13:48
@theHenks theHenks added the enhancement New feature or request label Oct 10, 2025
@fhagemann

Copy link
Copy Markdown
Contributor

Not sure if my review is still requested, but can you also show an example plot for the 2D LQ CTC?

@fhagemann

Copy link
Copy Markdown
Contributor

And you might want to add tests to compose the plot to keep the code coverage at 100% 😅

@fhagemann

fhagemann commented Nov 29, 2025

Copy link
Copy Markdown
Contributor

What's up with this?
As long as you add some tests with fake dummy data to trigger the plot recipe in the tests, this should be good to go.

@DaGeibl

DaGeibl commented Nov 29, 2025

Copy link
Copy Markdown
Contributor Author

Yeah sry,
this LQ update is currently still on ice here and in SpecFits, as I had do focus on the new data. As soon as we look there a bit deeper into PSD I should have time again to finish this up.

@DaGeibl
DaGeibl marked this pull request as draft January 13, 2026 12:18
@DaGeibl

DaGeibl commented Jan 13, 2026

Copy link
Copy Markdown
Contributor Author

Converted back to draft as long as this PR is on ice.
I will open it as soon as I think that we can merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants