Improve article validation and test coverage#22
Merged
Conversation
leesunghyun
marked this pull request as ready for review
June 27, 2026 10:14
Owner
Author
|
Remaining follow-up: manual smoke validation is still marked unchecked in PR verification. I recommend running a quick 10~20 second emulator smoke pass (edit/save/back cases) and then checking this item manually. |
Owner
Author
|
실기기(R5CN30C32XB, SM_G9860)에서 수동 스모크 시나리오 검증 완료했습니다. 검증 절차:
결과:
PR 체크리스트 [ ] 항목은 실기기 기준으로 완료 처리 가능합니다. |
Owner
Author
|
실기기 검증 결과 보완 공지:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
1) Article detail UX (validation)
app/src/main/java/com/example/viewmodelmigration/ui/ArticleDetailScreen.kt2) Reducer safety and tests
app/src/main/java/com/example/viewmodelmigration/core/ArticleListReducer.ktSelectArticlenow validates requested article id exists before setting selectionapp/src/test/java/com/example/viewmodelmigration/core/ArticleListReducerTest.ktselectArticle_invalidId_clearsSelectionForInvalidStateSafety3) Compose UI smoke coverage
app/src/androidTest/java/com/example/viewmodelmigration/ArticleUiSmokeTest.ktsaveButton_isDisabledAndShowsValidation_whenRequiredFieldsAreEmptybackWithoutSave_keepsOriginalArticleInList4) Docs / release alignment
README.md: removed demo placeholder note and updated v0.2 checklistdocs/release-notes-v0.2.0-oss-alpha.1.md: updated demo-planning wordingdocs/roadmap-v0.2.0.md: marked demo replacement as completedocs/images/demo.gif: replaced placeholder with real emulator demo recordingVerification
./gradlew test(via GitHub Actions:Android CI)./gradlew assembleDebug(via GitHub Actions:Android CI)