feat: add sd-server API support for steps, sampler and scheduler #1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I believe it would be better to exclude the Python web client from this PR and keep the scope limited to server-related changes. |
Owner
I think we could limit the number of steps to a maximum value, for example, 100. |
wbruna
force-pushed
the
sd_server_steps
branch
from
d0b291c to
fe3ae56
Compare
Contributor
For reference, I have seen distillations that use 150steps as reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #1166 just to make it easier to test.
The step numbers should probably be limited in some way?