Skip to content

Conversation

@akolson
Copy link
Member

@akolson akolson commented Jan 27, 2026

Summary

This pr removes all residual code from the remove of the styleOverrides prop.

References

Closes #13852

Reviewer guidance

  • Install the Safe Html5 plugin by running kolibri plugin enable kolibri.plugings.safe_html5_viewer
  • Run Kolibri and view HTML5 content
  • Ensure no regressions

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes remaining styleOverrides prop usage from the SafeHTML image rendering flow and replaces window-size-dependent logic with useKResponsiveWindow.

Changes:

  • Removed styleOverrides prop plumbing from SafeHtmlImageLightbox.
  • Added useKResponsiveWindow usage in Lightbox to compute sizing based on windowIsSmall.
  • Updated lightbox sizing calculations to no longer depend on styleOverrides.windowSizeClass.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/kolibri-common/components/SafeHTML/SafeHtmlImage.vue Stops accepting/passing styleOverrides when opening the lightbox.
packages/kolibri-common/components/SafeHTML/Lightbox.vue Uses useKResponsiveWindow to determine small-window sizing instead of styleOverrides.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants