-
Notifications
You must be signed in to change notification settings - Fork 878
Removes residue style overrides prop code #14112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-v0.19.x
Are you sure you want to change the base?
Removes residue style overrides prop code #14112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Removes remaining styleOverrides prop usage from the SafeHTML image rendering flow and replaces window-size-dependent logic with useKResponsiveWindow.
Changes:
- Removed
styleOverridesprop plumbing fromSafeHtmlImage→Lightbox. - Added
useKResponsiveWindowusage inLightboxto compute sizing based onwindowIsSmall. - Updated lightbox sizing calculations to no longer depend on
styleOverrides.windowSizeClass.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/kolibri-common/components/SafeHTML/SafeHtmlImage.vue | Stops accepting/passing styleOverrides when opening the lightbox. |
| packages/kolibri-common/components/SafeHTML/Lightbox.vue | Uses useKResponsiveWindow to determine small-window sizing instead of styleOverrides. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Summary
This pr removes all residual code from the remove of the
styleOverridesprop.References
Closes #13852
Reviewer guidance
kolibri plugin enable kolibri.plugings.safe_html5_viewer