Clean up localeCompare usage for proper internationalization (fixes #3888) #14087
+62
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Facility
rtibbles
force-pushed
the
claude/review-kolibri-issue-3888-017nnZLVRzfZRPKEp8jegFBb
branch
from
ab884a4 to
6d6e230
Compare
…earningequality#3888) Use the localeCompare wrapper from i18n.js consistently across sorting operations to ensure proper locale-aware string comparison.
rtibbles
force-pushed
the
claude/review-kolibri-issue-3888-017nnZLVRzfZRPKEp8jegFBb
branch
from
6d6e230 to
9aa8b40
Compare
Contributor
Build Artifacts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes usage of the
localeComparewrapper fromi18n.jsacross all sorting operations to ensure proper locale-aware string comparison.Changes:
localeComparewrapper in i18n.js to default tocurrentLanguageandusage: 'sort'.localeCompare()callscompareLanguages()to use proper locale-aware comparisonScreenshots showing sorted lists work correctly:
References
Fixes #3888
Reviewer guidance
The changes are mechanical - replacing direct
.localeCompare()calls with the centralized wrapper. No risky areas (no auth, migrations, or API changes).To verify: sorting of user/class lists should work correctly for names with accented characters and non-Latin scripts.