Add channel token support to importchannel management command #14056
+285
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DEV: dev-ops
rtibbles
force-pushed
the
claude/plan-import-issue-01PLz3FuYjwoyrk7gttdFysn
branch
from
7f66ea8 to
f9d039f
Compare
Contributor
Build Artifacts
|
rtibbles
removed
SIZE: very large
DEV: dev-ops
rtibbles
force-pushed
the
claude/plan-import-issue-01PLz3FuYjwoyrk7gttdFysn
branch
from
f9d039f to
a9dbaa8
Compare
Implements support for using channel tokens in addition to channel IDs when importing channels via the importchannel command, addressing issue #3733. Key features: - Token resolution via channel lookup API (works with Studio or any Kolibri instance) - Automatic detection of tokens vs channel IDs using UUID validation - Interactive multi-channel selection when token resolves to multiple channels - Non-interactive mode shows error with all channel options - Comprehensive error handling with user-friendly messages - Full backward compatibility with existing channel ID usage Implementation details: - Added resolve_channel_token() utility in paths.py using duck typing - Returns tuple of (channel_id, all_channels) for flexible handling - Command detects TTY to determine interactive vs non-interactive mode - Interactive mode prompts user to choose from numbered list - Non-interactive mode fails with clear error listing all options - Only network subcommand supports tokens (disk requires UUIDs) Error handling improvements: - JSON parse errors caught with helpful messages - Network failures, invalid tokens, malformed responses all handled - Validates all channels have IDs before returning - Clear error messages guide users to resolution Test coverage: - Token resolution (single and multiple channels) - Invalid JSON responses - Missing channel IDs - Default and custom baseurl - All error paths covered Fixes #3733
rtibbles
force-pushed
the
claude/plan-import-issue-01PLz3FuYjwoyrk7gttdFysn
branch
from
a9dbaa8 to
940d830
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for using channel tokens in addition to channel IDs when importing channels via the
importchannelmanagement command.Key features:
Example usage:
References
Fixes #3733
Reviewer guidance
networksubcommand;diskrequires UUIDs since tokens need network access to resolveresolve_channel_token()and integration tests intest_import_export.py